Skip to content

Add line limits and env variable configs#2115

Draft
olaservo wants to merge 3 commits intomodelcontextprotocol:mainfrom
olaservo:filesystem-followups
Draft

Add line limits and env variable configs#2115
olaservo wants to merge 3 commits intomodelcontextprotocol:mainfrom
olaservo:filesystem-followups

Conversation

@olaservo
Copy link
Copy Markdown
Member

Description

Server Details

  • Server: filesystem
  • Changes to: tools

Motivation and Context

There were some followups needed from this older PR: #1027

How Has This Been Tested?

Will add tests after this jest setup is merged: #1405

Breaking Changes

None

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Protocol Documentation
  • My changes follows MCP security best practices
  • I have updated the server's README accordingly
  • I have tested this with an LLM client
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have documented all environment variables and configuration options

@olaservo olaservo changed the title Ad line limits and env variable configs Add line limits and env variable configs Jun 17, 2025
@olaservo olaservo added server-filesystem Reference implementation for the Filesystem MCP server - src/filesystem enhancement New feature or request labels Jun 17, 2025
@olaservo
Copy link
Copy Markdown
Member Author

@claude please add tests that will cover the functionality being added in this PR.

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented Aug 17, 2025

Claude encountered an error —— View job

Failed with exit code 128

I'll analyze this and get back to you.

Comment thread src/filesystem/index.ts Outdated
@domdomegg
Copy link
Copy Markdown
Member

@olaservo are you able to try pushing your changes to a branch on the main servers repo, rather than your own repo? Not sure if you have perms, but maybe give it a shot? I think that will allow Claude to respond.

I'm still chasing internally about getting it working on forks - turns out to be a tricky problem security wise.

Co-authored-by: adam jones <domdomegg+git@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request server-filesystem Reference implementation for the Filesystem MCP server - src/filesystem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants